Hi!
On 5/23/23 22:58, наб wrote:
> On Tue, May 23, 2023 at 10:20:07PM +0200, Alejandro Colomar wrote:
>> On 5/23/23 22:17, наб wrote:
>>> @@ -119,7 +119,8 @@ .SH HISTORY
>>> On the one hand this causes a memory leak, and on the other hand
>>> it violates SUSv2.
>>> .PP
>>> -The 4.4BSD version, like glibc 2.0, uses a copy.
>>> +The 4.3BSD-Reno version, like glibc 2.0, uses a copy;
>> Maybe we should say s/uses/used/?
> 4.3BSD-Reno is a single release and hence a single version,
> and nothing's changed about it, so it still "is".
>
> We could say "The BSD used" but we have hard versions, so.
>
> The same holds for the first long line in HISTORY:
> The putenv() function is not required to be reentrant, and the one in
> glibc 2.0 is not, but the glibc 2.1 version is.
> the singular version which was part of the glibc 2.0 release(s) hasn't
> changed in glibc 2.0, and glibc 2.0 "is" (but yeah, glibc "was").
>
> Present tense also appears to be a prevalent style globally:
> setuid(2) says "Not quite compatible with the 4.4BSD call, which sets
> all of the real, saved, and effective user IDs."
> setjmp(3) says "In 4.3BSD it will, and there is a function _setjmp()
> that will not."
Makes sense. I applied both patches. And put your signature in
this one.
BTW:
$ git log | grep nabijacz | sort | uniq
Cc: Ahelenia Ziemiańska <nabijaczleweli@xxxxxxxxxxxxxxxxxx>
Cc: наб <nabijaczleweli@xxxxxxxxxxxxxxxxxx>
Reported-by: Ahelenia Ziemiańska <nabijaczleweli@xxxxxxxxxxxxxxxxxx>
Reported-by: наб <nabijaczleweli@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@xxxxxxxxxxxxxxxxxx>
Author: Ahelenia Ziemiańska <nabijaczleweli@xxxxxxxxxxxxxxxxxx>
Author: наб <nabijaczleweli@xxxxxxxxxxxxxxxxxx>
Would you add yourself to .mailmap with your preferred name? Or
do you prefer to keep the ambiguity maybe? :-)
Cheers,
Alex
>
> Best,
--
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
