On Fri, 21 Apr 2023 at 20:45, Alejandro Colomar <alx.manpages@xxxxxxxxx> wrote:
> > diff --git a/man7/bpf-helpers.7 b/man7/bpf-helpers.7
> > index 26ddf8369..663dfd1d1 100644
> > --- a/man7/bpf-helpers.7
> > +++ b/man7/bpf-helpers.7
> > @@ -3025,7 +3025,7 @@ copied and the last byte is set to NUL.
> > On success, returns the number of bytes that were written,
> > including the terminal NUL. This makes this helper useful in
> > tracing programs for reading strings, and more importantly to
> > -get its length at runtime. See the following snippet:
> > +get its length at run time. See the following snippet:
>
> Good, but bpf-helpers.7 is generated from kernel sources. This
> one will depend on what kernel developers want. I CCed Quentin,
> since he's nice and might be able to tell if BPF guys are
> interested in this kind of wording fixes.
Hi Günther, Alejandro,
Yes, this page is generated from the comments in
include/uapi/linux/bpf.h, in the kernel repository. From the root of
the repo, you can visualise the changes with:
$ ./scripts/bpf_doc.py | rst2man | man -l -
I can't speak for the rest of BPF folks, but personally I'm OK with
the patch, especially if it makes spelling more consistent between man
pages. Patches for this file should target the bpf-next tree
(https://docs.kernel.org/bpf/bpf_devel_QA.html#submitting-patches).
Thanks,
Quentin
