Re: [PATCH v5 1/8] regex.3: Desoupify regcomp() description

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi наб!

On 4/20/23 17:35, наб wrote:
> Behold:
>   regerror() is passed the error code, errcode, the pattern buffer,
>   preg, a pointer to a character string buffer, errbuf, and the size
>   of the string buffer, errbuf_size.
> 
> Absolute soup. This reads to me like an ill-conceived copy from a very

Single space after period is evil.  I'd like to point you to this rant
o'mine where I give more details, to not repeat myself too much:
<https://lore.kernel.org/linux-man/9c5c5744-dde0-b333-09e0-ba9d92aa96b1@xxxxxxxxx/T/#mb4eb99c9bccb59c6df82c1f6945766c878d85f07>

I've cleaned up those crimes before applying, and then applied this
patch.  :)

Cheers,

Alex


> early standard version. It looks fine in source form but is horrific to
> read as running text.
> 
> Instead, replace all of these with just the descriptions of what they do
> with their arguments. What the arguments are is very clearly noted in
> big bold in the prototypes.
> 
> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@xxxxxxxxxxxxxxxxxx>
> ---
>  man3/regex.3 | 22 +++++++---------------
>  1 file changed, 7 insertions(+), 15 deletions(-)
> 
> diff --git a/man3/regex.3 b/man3/regex.3
> index 129c42412..2f6ee816f 100644
> --- a/man3/regex.3
> +++ b/man3/regex.3
> @@ -38,21 +38,13 @@ .SS Compilation
>  .BR regexec ()
>  searches.
>  .PP
> -.BR regcomp ()
> -is supplied with
> -.IR preg ,
> -a pointer to a pattern buffer storage area;
> -.IR regex ,
> -a pointer to the null-terminated string and
> -.IR cflags ,
> -flags used to determine the type of compilation.
> -.PP
> -All regular expression searching must be done via a compiled pattern
> -buffer, thus
> -.BR regexec ()
> -must always be supplied with the address of a
> -.BR regcomp ()-initialized
> -pattern buffer.
> +On success, the pattern buffer at
> +.I *preg
> +is initialized.
> +.I regex
> +is a null-terminated string.
> +The locale must be the same when running
> +.BR regexec ().
>  .PP
>  .I cflags
>  is the

-- 
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux