Hi! On Thu, Apr 20, 2023 at 01:43:56PM +0200, Alejandro Colomar wrote: > On 4/20/23 13:15, наб wrote: > > Behold: > > regerror() is passed the error code, errcode, the pattern buffer, > > preg, a pointer to a character string buffer, errbuf, and the size > > of the string buffer, errbuf_size. > > > > Absolute soup. This reads to me like an ill-conceived copy from a very > > early standard version. It looks fine in source form but is horrific to > > read as running text. > > > > Instead, replace all of these with just the descriptions of what they do > > with their arguments. What the arguments are is very clearly noted in > > big bold in the prototypes. > It would be nice to see the --range-diff[1], to easily review changes to > patches. I have a hard time running vdiff[2] on the raw patches. v2: > > -against the precompiled pattern buffer, > > +against the precompiled pattern buffer in v3: > > -against the precompiled pattern buffer, > > +against the compiled pattern buffer in And 9/9 grew this hunk in v3: @@ -179,13 +179,13 @@ the match succeeded, and > 0), they overwrite .I pmatch as usual, and the -.B Byte offsets +.B Match offsets remain relative to .IR string (not Best,
Attachment:
signature.asc
Description: PGP signature
