Hi Lukas, On 4/11/23 10:43, Lukas Javorsky wrote: > I fixed the issues you pointed out, thank you for that. $ git apply patches/Re\:\ \[PATCH\]\ resolv.conf.5\:\ Add\ option\ no-aaaa\ to\ the\ resolv.conf\ manual\ page\ -\ Lukas\ Javorsky\ \<ljavorsk@xxxxxxxxxx\>\ -\ 2023-04-11\ 1043.eml error: corrupt patch at line 118 After manually fixing that in the patch (which was due to your mailer inserting line breaks), it fails with: $ git apply patches/Re\:\ \[PATCH\]\ resolv.conf.5\:\ Add\ option\ no-aaaa\ to\ the\ resolv.conf\ manual\ page\ -\ Lukas\ Javorsky\ \<ljavorsk@xxxxxxxxxx\>\ -\ 2023-04-11\ 1043.eml error: patch failed: man5/resolv.conf.5:200 error: man5/resolv.conf.5: patch does not apply I'm not sure what's the reason for this; maybe some strange character; I can't see problems by visual inspection. Can you resend including a copy attached so that the mailer can't break it? Thanks, Alex > > --- > man5/resolv.conf.5 | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/man5/resolv.conf.5 b/man5/resolv.conf.5 > index 6af8b4e92..2dd051556 100644 > --- a/man5/resolv.conf.5 > +++ b/man5/resolv.conf.5 > @@ -200,6 +200,29 @@ which causes round-robin selection of name > servers from among those listed. > This has the effect of spreading the query load among all listed servers, > rather than having all clients try the first listed server first every time. > .TP > +.B no\-aaaa (since glibc 2.36) > +.\" f282cdbe7f436c75864e5640a409a10485e9abb2 > +Sets > +.B RES_NOAAAA > +in > +.IR _res.options , > +which suppresses AAAA queries made by the stub resolver, > +including AAAA lookups triggered by NSS-based interfaces such as > +.BR getaddrinfo (3). > +Only DNS lookups are affected: IPv6 data in > +.BR hosts (5) > +is still used, > +.BR getaddrinfo (3) > +with > +.B AI_PASSIVE > +will stillproduce IPv6 addresses, > +and configured IPv6 name servers are still used. > +To produce correct Name Error (NXDOMAIN) results, > +AAAA queries are translated to A queries. > +This option is intended preliminary for diagnostic purposes, > +to rule out that AAAA DNS queries have adverse impact. > +It is incompatible with EDNS0 usage and DNSSEC validation by applications. > +.TP > .B no\-check\-names > .\" since glibc 2.2 > Sets > -- > 2.39.2 > > If you see anything else, please let me know. > > > On Sat, Apr 8, 2023 at 3:22 PM Alejandro Colomar <alx.manpages@xxxxxxxxx> wrote: >> >> Hi Lukas, >> >> On 4/6/23 15:11, Lukas Javorsky wrote: >>> Reference: https://sourceware.org/pipermail/libc-alpha/2022-June/139549.html >> >> Thanks for the patch. Please see a few comments below. >> >> BTW, your mailer screws the patch; please send a copy attached together >> with the inline patch in the email, so I can respond to the inline one >> but apply the attached one. >> >> Cheers, >> Alex >> >>> --- >>> man5/resolv.conf.5 | 21 +++++++++++++++++++++ >>> 1 file changed, 21 insertions(+) >>> >>> diff --git a/man5/resolv.conf.5 b/man5/resolv.conf.5 >>> index 6af8b4e92..2dd051556 100644 >>> --- a/man5/resolv.conf.5 >>> +++ b/man5/resolv.conf.5 >>> @@ -200,6 +200,27 @@ which causes round-robin selection of name servers >>> from among those listed. >>> This has the effect of spreading the query load among all listed servers, >>> rather than having all clients try the first listed server first every >>> time. >>> .TP >>> +.B no\-aaaa (since glibc 2.36) >>> +.\" f282cdbe7f436c75864e5640a409a10485e9abb2 >>> +Sets >>> +.BR RES_NOAAAA >> >> This adds a warning: >> >> an.tmac:man5/resolv.conf.5:206: style: .BR expects at least 2 arguments, got 1 >> >> You should use '.B', not '.BR'. >> >> Please check this for preventing new warnings: >> <https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/tree/CONTRIBUTING#n132> >> >> (Although I'm not sure if this warning is only enabled in a version >> of groff(1) that you probably don't have. :) >> >>> +in >>> +.IR _res.options , >>> +which suppresses AAAA queries made by the stub >> >> Please use semantic newlines. See man-pages(7): >> >> Use semantic newlines >> In the source of a manual page, new sentences should be started >> on new lines, long sentences should be split into lines at >> clause breaks (commas, semicolons, colons, and so on), and long >> clauses should be split at phrase boundaries. This convention, >> sometimes known as "semantic newlines", makes it easier to see >> the effect of patches, which often operate at the level of in‐ >> dividual sentences, clauses, or phrases. >> >> >>> +resolver, including AAAA lookups triggered by NSS-based interfaces >>> +such as >>> +.BR getaddrinfo (3). >>> +Only DNS lookups are affected: IPv6 data in >>> +.BR hosts (5) >>> +is still used, >>> +.BR getaddrinfo (3) >>> +with AI_PASSIVE will still >> >> .B AI_PASSIVE >> >> (I see it's not formatted in other locations in this file; that seems >> a bug.) >> >>> +produce IPv6 addresses, and configured IPv6 name servers are still >>> +used. To produce correct Name Error (NXDOMAIN) results, AAAA queries >>> +are translated to A queries. This option is intended preliminary >>> +for diagnostic purposes, to rule out that AAAA DNS queries have adverse >>> impact. >>> +It is incompatible with EDNS0 usage and DNSSEC validation by applications. >>> +.TP >>> .B no\-check\-names >>> .\" since glibc 2.2 >>> Sets >>> -- >>> 2.39.2 >>> >> >> -- >> <http://www.alejandro-colomar.es/> >> GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5 > > > -- <http://www.alejandro-colomar.es/> GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
