Re: [PATCH] landlock.7: ffix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Tom,

On 3/8/23 09:56, Tom Schwindl wrote:
> Signed-off-by: Tom Schwindl <schwindl@xxxxxxxxx>
> ---
>  man7/landlock.7 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/man7/landlock.7 b/man7/landlock.7
> index b2bc9e10b0c0..bbe00d4c2793 100644
> --- a/man7/landlock.7
> +++ b/man7/landlock.7
> @@ -245,7 +245,7 @@ attr.handled_access_fs =
>          LANDLOCK_ACCESS_FS_MAKE_SYM;
>  
>  ruleset_fd = landlock_create_ruleset(&attr, sizeof(attr), 0);
> -if (ruleset_fd == -1) {
> +if (ruleset_fd == \-1) {
>      perror("Failed to create a ruleset");
>      exit(EXIT_FAILURE);
>  }
> @@ -276,7 +276,7 @@ path_beneath.allowed_access =
>          LANDLOCK_ACCESS_FS_READ_DIR;
>  
>  path_beneath.parent_fd = open("/usr", O_PATH | O_CLOEXEC);
> -if (path_beneath.parent_fd == -1) {
> +if (path_beneath.parent_fd == \-1) {
>      perror("Failed to open file");
>      close(ruleset_fd);
>      exit(EXIT_FAILURE);

Thanks for the patch!  Now that you're at it, would you mind fixing
a few other cases in printf.h.3head in the same patch?  I see the
following:

$ grep -rn '^[^.].* -1' man*
man3head/printf.h.3head:291:    if (register_printf_specifier(\[aq]b\[aq], b_printf, b_arginf_sz) == -1)
man3head/printf.h.3head:293:    if (register_printf_specifier(\[aq]B\[aq], b_printf, b_arginf_sz) == -1)
man3head/printf.h.3head:413:        return -1;
man7/landlock.7:248:if (ruleset_fd == -1) {
man7/landlock.7:279:if (path_beneath.parent_fd == -1) {


Cheers,

Alex

-- 
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux