Hi Alejandro,
On Sun, Feb 5, 2023 at 6:21 AM Alejandro Colomar <alx.manpages@xxxxxxxxx> wrote:
>
> Hi Namhyung,
>
> On 1/17/23 09:08, Namhyung Kim wrote:
> > From: Namhyung Kim <namhyung@xxxxxxxxxx>
> >
> > Add missing perf_event_attr fields, new event codes and sample type.
> > Also add descriptions for PERF_FORMAT_LOST.
> >
> > Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
> > ---
> > man2/perf_event_open.2 | 201 +++++++++++++++++++++++++++++++++++++++--
> > 1 file changed, 193 insertions(+), 8 deletions(-)
> >
> > diff --git a/man2/perf_event_open.2 b/man2/perf_event_open.2
> > index 8e94fb4ac..05f06cf68 100644
> > --- a/man2/perf_event_open.2
> > +++ b/man2/perf_event_open.2
>
> [...]
>
> > @@ -2201,7 +2332,9 @@ struct {
> > char data[size]; /* if PERF_SAMPLE_STACK_USER */
> > u64 dyn_size; /* if PERF_SAMPLE_STACK_USER &&
> > size != 0 */
> > - u64 weight; /* if PERF_SAMPLE_WEIGHT */
> > + union perf_sample_weight;
>
> This is a type declaration, but defines no storage. Did you intend to use it as
> an anonymous union, or did you accidentally miss a variable name?
Oh, I missed the name. Will update.
Thanks,
Namhyung
>
> > + /* if PERF_SAMPLE_WEIGHT */
> > + /* || PERF_SAMPLE_WEIGHT_STRUCT */
> > u64 data_src; /* if PERF_SAMPLE_DATA_SRC */
> > u64 transaction; /* if PERF_SAMPLE_TRANSACTION */
> > u64 abi; /* if PERF_SAMPLE_REGS_INTR */
> > @@ -2209,6 +2342,12 @@ struct {
> > /* if PERF_SAMPLE_REGS_INTR */
> > u64 phys_addr; /* if PERF_SAMPLE_PHYS_ADDR */
> > u64 cgroup; /* if PERF_SAMPLE_CGROUP */
> > + u64 data_page_size;
> > + /* if PERF_SAMPLE_DATA_PAGE_SIZE */
> > + u64 code_page_size;
> > + /* if PERF_SAMPLE_CODE_PAGE_SIZE */
> > + u64 size; /* if PERF_SAMPLE_AUX */
> > + char data[size]; /* if PERF_SAMPLE_AUX */
> > };
> > .EE
> > .in
> [...]
>
> --
> <http://www.alejandro-colomar.es/>
> GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
