Re: Revert 70ac1c478 ("src.mk, All pages: Move man* to man/")

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Alejandro,

thanks a lot for your feedback.

> Hi Petr,

> On 9/6/22 11:41, Petr Vorel wrote:
> > Hi Alejandro,

> > yesterday you merged this commit (without sending it to ML):
> > 70ac1c478 ("src.mk, All pages: Move man* to man/")


> It's good to know that someone realized immediately after my patch.  I
> wanted to know how much it would really hurt others' habits, and a
> discussion about it would probably have been too artificial.  That's why I
> did it without prior discussion.

> > Although I agree that number of man* is quite high and single man directory
> > looks nicer, from practical reasons I'd prefer to revert this commit.
> > Because saving one extra cd is IMHO more important.

> I rarely cd.  I edit pages from the root of the repo with (in my example,
> I'll pretend to edit membarrier(2)):
I also rarely cd. Both cd and editing from the git root directory use using tab
autocompletion as you note below.

> (previous to subsections):
> vi m[TAB]2[TAB]memb[TAB]

> (after subsections were introduced, but before this change):
> vi m[TAB]2/memb[TAB]

> (after this patch):
> vi m[TAB]m[TAB]2/memb[TAB]


> I agree it's two more keystrokes, and it took me so long to decide to change
> it because two keystrokes all the time are not the most friendly thing in
> the world, but I think I could live with them.

> Do you still think I should revert it?
I'd wait for more feedback, maybe others will like it.
Sure, I can live with it if I'm alone who even noticed :).

> I guess I'll receive a lot more emails like that in the following days, so
> I'll wait a little bit more before considering reverting it, but yeah, I may
> do it; I'm still unsure about what to do.
No matter how you finally decide, the most important lesson is that tree wide
changes, although they look trivial are safer to post to ML to get feedback
before (and obviously anything which looks controversial).

Kind regards,
Petr

> Kind regards,

> Alex



[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux