On 7/19/22 14:17, Alejandro Colomar wrote:
Hi, наб and Branden! On 7/19/22 03:56, наб wrote:FreeBSD timezone(3) is V7 char *timezone(int zone, int dst), our documentation would imply it's impossible to service this type of system portably Indeed, glibc defines them both, and they make more sense for most use-cases than trying to use the globalsGreat!glibc cited for __USE_MISC, tm_zone invalidation is Debian 2.33-7But I guess it is present in much older glibcs, right? Otherwise we should add a VERSIONS thingy.POSIX cited for XSI marking is Issue 7 TC2 CSRG CD #2 contains 4.3BSD-Tahoe with both members This also fixes the multiple lies in man-pages 5.10 localtime(3), which says only: The glibc version of struct tm has additional fields const char *tm_zone; /* Timezone abbreviation */ defined when _BSD_SOURCE was set before including <time.h>. This is a BSD extension, present in 4.3BSD-Reno.Did you forget that removal of lies? I don't see it in the patch.Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@xxxxxxxxxxxxxxxxxx> --- man3/tm.3type | 45 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/man3/tm.3type b/man3/tm.3type index 1931d890d..8b6f8d9bf 100644 --- a/man3/tm.3type +++ b/man3/tm.3type @@ -25,8 +25,26 @@ Standard C library .BR " int tm_yday;" \ " /* Day of the year [" 0 ", " 365 "] (Jan/01 = " 0 ") */" .BR " int tm_isdst;" " /* Daylight savings flag */" + +.BR " long tm_gmtoff;" " /* Seconds East of UTC */" +.BR " char*tm_zone;" " /* Timezone abbreviation */"Please add cosmetic whitespace (at least 1 for every member, possibly 2, depending on your taste) :)
BTW, since this commit is already adding a lot of stuff, I prefer if you add the whitespace in a separate commit.
Thanks, Alex -- Alejandro Colomar <http://www.alejandro-colomar.es/>
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
