Hi, Peter and Branden! On 6/6/22 23:33, G. Branden Robinson wrote:
[CC list trimmed since this is solely about English and *roff] At 2022-06-06T15:40:08-0400, Peter Xu wrote:I think the patch below would improve a little bit the wording (and newlines). I still have a bit of trouble understanding "When a kernel-originated fault was triggered on the registered range with this userfaultfd". Did you maybe mean "range registered" instead of "registered range"?Since I'm not a native speaker I don't immediately see the difference between the two.Short answer: I think your existing wording is acceptable. As a native speaker (but not a trained linguist) I think I can speak to the subject: both forms are equivalent in this application. In standard English, adjectives usually precede the nouns they modify.
[...] But in this case,"When a kernel-originated fault was triggered on the registered range with this userfaultfd"
"registered" is not acting as an adjective, but as a verb. Maybe Peter was confused by that; I didn't consider that option. I'm actually surprised that you were, Branden, but I guess it was just a neuron going crazy, as mine with \c the other day :p
It's always challenging for me to grasp how you prefer the newlines are made, but anyway below changes looks good to me.
Sorry, Peter. I'll take that into account, and try to help as much as I can. Apart from what Branden has already added to this thread, the following man-pages commit has some more details, quoted from B. W. Kernighan, and may help you understand what I want:
<https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/commit/man7/man-pages.7?h=alx/main&id=6ff6f43d68164f99a8c3fb66f4525d145571310c>I have a long-standing discussion with Branden regarding how much should I push for semantic newlines. The origin of using semantic newlines is only to simplify diffs (and it does that very well), but for some reason, my brain reads the text better too when organized that way, as opposed to normal prose-like text flow. There I seem to disagree with Branden, who prefers to read my emails as if they were a book. Maybe I need semantic newlines to understand the text better, because there are a lot of technical terms that I don't know, and having less load on my brain (because I don't need to calculate phrase boundaries) makes it easier; it's especially useful when text is under development, where it may have mistakes that make it even more difficult to read.
But, just do what you can. I'll try to do the rest, and ask you if I don't understand something.
So we can safely say that it's a 40-year tradition, at least. To some, however, its age may not recommend it. ;-)
;-)
Fault-handling in user mode is certainly arriving none too soon. Thank you for your work on it.
Yup, thanks for your work Peter!
Regards, Branden [1] https://owl.purdue.edu/owl/general_writing/grammar/that_vs_which.html [2] See what I did there?
Yes :)
[3] https://english.stackexchange.com/questions/264236/can-any-verbs-present-and-past-participles-be-used-as-adjectives
Cheers, Alex -- Alejandro Colomar <http://www.alejandro-colomar.es/>
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
