Hi Jesse, On 6/3/22 16:45, Jesse Rosenstock wrote:
Change "supported only since" to "support was added in". Previously, this said, "MAP_POPULATE is supported for private mappings only since Linux 2.6.23." This could be parsed as "MAP_POPULATE is supported for private mappings only [not shared mappings] since Linux 2.6.23." Someone (a native English speaker) tried to tell me this. Change to "Support for MAP_POPULATE in conjunction with private mappings was added in Linux 2.6.23." This is unambiguous, and "support was added" is more common in other man pages. There are more instances of "supported only since", but they seem clearer. I could send a separate patch for them if desired. Signed-off-by: Jesse Rosenstock <jmr@xxxxxxxxxx>
The patch makes sense to me. If you consider other patches would be good too, send them and I'll have a look at them.
Patch applied. Thanks, Alex
--- man2/mmap.2 | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/man2/mmap.2 b/man2/mmap.2 index 96b7444b0..b9cfe82a6 100644 --- a/man2/mmap.2 +++ b/man2/mmap.2 @@ -215,11 +215,11 @@ The argument should be zero. .\" See the pgoff overflow check in do_mmap(). .\" See the offset check in sys_mmap in arch/x86/kernel/sys_x86_64.c. -The use of +Support for .B MAP_ANONYMOUS in conjunction with .B MAP_SHARED -is supported on Linux only since kernel 2.4. +was added in Linux 2.4. .TP .B MAP_DENYWRITE This flag is ignored. @@ -405,8 +405,9 @@ The call doesn't fail if the mapping cannot be populated (for example, due to limitations on the number of mapped huge pages when using .BR MAP_HUGETLB ). +Support for .BR MAP_POPULATE -is supported for private mappings only since Linux 2.6.23. +in conjunction with private mappings was added in Linux 2.6.23. .TP .BR MAP_STACK " (since Linux 2.6.27)" Allocate the mapping at an address suitable for a process -- 2.36.1.255.ge46751e96f-goog
-- Alejandro Colomar <http://www.alejandro-colomar.es/>
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
