On Fri 05-11-21 03:05:44, xuyang2018.jy@xxxxxxxxxxx wrote: > ps:I also increase ltp quotactl coverage to cover quotactl_fd syscall. I > would appreciate it if you could review my ltp quotactl/quotactl_fd patchset > https://patchwork.ozlabs.org/project/ltp/list/?series=269166 >From a quick look the patches look fine. Just one thing I've noticed - you seem to open "mntpoint/testfile" so that you have 'fd' to pass to quotactl_fd(). Why don't you just open "mntpoint" directly? Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
