Re: [PATCH 04/32] vdso.7: Add y2038 compliant gettime for ppc/32

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Alex,

On 8/8/21 3:01 AM, Alejandro Colomar (man-pages) wrote:
> Hello Michael,
> 
> On 8/8/21 2:48 AM, Michael Kerrisk (man-pages) wrote:
>> Hello Alex
>>
>> Again, let us add the bug in the commit message:
>>
>> https://bugzilla.kernel.org/show_bug.cgi?id=213421
> 
> Sure.
> 
>>
>> I have not yet applied this. See below.
>>
>> On 7/28/21 10:19 PM, Alejandro Colomar wrote:
>>> Christophe Leroy via Bugzilla:
>>>
>>> [
>>> https://man7.org/linux/man-pages/man7/vdso.7.html (2021-03-22)
>>>
>>> In ppc32 functions section, the Y2038 compliant function
>>> __kernel_clock_gettime64() is missing.
>>>
>>> It was added by commit d0e3fc69d00d
>>> ("powerpc/vdso: Provide __kernel_clock_gettime64() on vdso32")
>>> ]
>>>
>>> .../linux$ git describe d0e3fc69d00d
>>> v5.10-rc2-76-gd0e3fc69d00d
>>>
>>> Reported-by: Christophe Leroy <christophe.leroy@xxxxxxxxxx>
>>> Signed-off-by: Alejandro Colomar <alx.manpages@xxxxxxxxx>
>>> ---
>>>   man7/vdso.7 | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/man7/vdso.7 b/man7/vdso.7
>>> index 1d527c38e..5fb22ab5e 100644
>>> --- a/man7/vdso.7
>>> +++ b/man7/vdso.7
>>> @@ -371,6 +371,7 @@ symbol	version
>>>   _
>>>   __kernel_clock_getres	LINUX_2.6.15
>>>   __kernel_clock_gettime	LINUX_2.6.15
>>> +__kernel_clock_gettime64	LINUX_5.10
>>
>> Is it really 5.10? By contrast, I see
>>
>> $ git describe --contains d0e3fc69d00d
>> v5.11-rc1~76^2~251
>>
>> And indeed the symbol __kernel_clock_gettime64
>> does not seem to be present in the Linux 5.10 sources.
> 
> It seems I was wrong.  I forgot --contains!
> It is 5.11.

Okay. I applied the patch below.

Cheers,

Michael

commit ae5cc0dc572116c9f4125a1de52e6c613e6659f3 (HEAD -> master)
Author: Michael Kerrisk <mtk.manpages@xxxxxxxxx>
Date:   Sun Aug 8 04:22:49 2021 +0200

    vdso.7: Minor tweak to Alejandro Colomar's patch
    
    The correct kernel version seems to 5.11, not 5.10:
    
    $ git describe --contains d0e3fc69d00d
    v5.11-rc1~76^2~251
    
    Signed-off-by: Michael Kerrisk <mtk.manpages@xxxxxxxxx>

diff --git a/man7/vdso.7 b/man7/vdso.7
index 4a7ab3111..e706701f0 100644
--- a/man7/vdso.7
+++ b/man7/vdso.7
@@ -370,7 +370,7 @@ symbol      version
 _
 __kernel_clock_getres  LINUX_2.6.15
 __kernel_clock_gettime LINUX_2.6.15
-__kernel_clock_gettime64       LINUX_5.10
+__kernel_clock_gettime64       LINUX_5.11
 __kernel_datapage_offset       LINUX_2.6.15
 __kernel_get_syscall_map       LINUX_2.6.15
 __kernel_get_tbfreq    LINUX_2.6.15


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/



[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux