Hi, Christian!
On 8/3/21 2:28 PM, Christian Brauner wrote:
Hi, Christian!
I applied your v4 patch.
On top of it I applied this fix.
Could you please check that the non-whitespace non-formatting
changes are correct?
Looks great.
Thanks.
Also, please have a look at the whitespace and formatting fixes :)
Yep, I did. You tried to make sure that all bullet points created via
\(bu are aligned with the regular text and not indented. You forgot one,
I think. I think you need the following patch on top of your patch:
Yup, good catch! Fixed.
Cheers,
Alex
diff --git a/man2/mount_setattr.2 b/man2/mount_setattr.2
index 29d308f65..70ab4592e 100644
--- a/man2/mount_setattr.2
+++ b/man2/mount_setattr.2
@@ -778,7 +778,6 @@ and let
.I ksize
be the size of the structure which the kernel supports,
then there are three cases to consider:
-.RS
.IP \(bu
If
.I ksize
@@ -815,7 +814,6 @@ then \-1 is returned and
is set to
.BR E2BIG .
This provides forwards-compatibility.
-.RE
.PP
Because the definition of
.I struct mount_attr
Thank you! Very happy we'll have a manpage for this soon.
Christian
--
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/
