[CC += Tobias, Mathias, Andrej]
Hi Michael,
On 5/10/21 1:45 AM, Michael Kerrisk (man-pages) wrote:
Hi Alex,
On 5/10/21 9:39 AM, Alejandro Colomar wrote:
Instead of having to write '|| exit $$?' all the time,
use the shell's '-Eeuo pipefail' options, which handle
errors even better. However, pipefail needs bash,
so POSIX sh (default) is not valid.
Signed-off-by: Alejandro Colomar <alx.manpages@xxxxxxxxx>
---
Hi Michael,
I'm not sure how much POSIX sh compatibility is needed for the man pages
Makefile. There are probably projects out there that don't have bash,
and still want to use it. So maybe we should't apply this. I don't know.
Up to you.
I think I'll skip this one. I'm not sure if it might cause some
problem for Debian, where the default shall is dash(1), I believe.
Debian has dash(1) as the default _non-interactive_ shell, but also has
bash(1) as the default _interactive_ shell. See
<https://wiki.debian.org/Shell>.
I can confirm that using Debian (sid) myself (and having not installed
bash(1) myself) I'm using this Makefile without any issue.
However, it's true that other smaller distros might not come with bash(1).
So still up to you :)
I forgot to CC the Debian maintainer of manpages in this patch this
time; fixed. I also CCed the bash(1) and dash(1) Debian maintainers,
just in case they have any comments.
Thanks,
Alex
--
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/
