Re: [PATCH v5 00/35] SYNOPSIS: Use syscall(SYS_...); and fix '#include's

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Michael,

On 4/5/21 1:49 PM, Michael Kerrisk (man-pages) wrote:
So, I think I'm okay with the syscall() changes in the SYNOPSIS.
It might just take me a moment to get used to them. However, I do
wonder if it is worth retaining a comment in the SYSNOPSIS,
something like:

    SYNOPSIS
        #include <asm/prctl.h>        /* Definition of ARCH_* constants */
        #include <sys/syscall.h>      /* Definition of SYS_* constants */
        #include <unistd.h>

        int syscall(SYS_arch_prctl, int code, unsigned long addr);
        int syscall(SYS_arch_prctl, int code, unsigned long *addr);

        Note: glibc provides no wrapper for arch_prctl(), necessitating
        the use of syscall(2).

Without something like this, the reader may be puzzled at the use of
syscall().

What do you think?

Yes.  I had doubts, and you confirmed them.  I'll add that.

Thanks,

Alex

--
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/



[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux