On 12/31/20 9:21 AM, Michael Kerrisk (man-pages) wrote: > On 12/31/20 12:22 AM, Alejandro Colomar (man-pages) wrote: >> >> >> On 12/30/20 11:40 PM, Michael Kerrisk (man-pages) wrote: >>> Hi Alewx, >>> >>> On 12/30/20 10:41 PM, Alejandro Colomar wrote: >>>> See glibc's commit: 0ce657c576bf1b24 >>>> https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=0ce657c576bf1b24 >>>> >>>> Reported-by: Jakub Wilk <jwilk@xxxxxxxxx> >>>> Signed-off-by: Alejandro Colomar <alx.manpages@xxxxxxxxx> >>>> --- >>>> man3/get_phys_pages.3 | 13 +++++++++---- >>>> 1 file changed, 9 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/man3/get_phys_pages.3 b/man3/get_phys_pages.3 >>>> index 35f83fedb..a8a1ce3f4 100644 >>>> --- a/man3/get_phys_pages.3 >>>> +++ b/man3/get_phys_pages.3 >>>> @@ -55,15 +55,20 @@ The system could not provide the required information >>>> (possibly because the >>>> .I /proc >>>> filesystem was not mounted). >>>> -.SH CONFORMING TO >>>> -These functions are GNU extensions. >>>> -.SH NOTES >>>> -These functions obtain the required information by scanning the >>>> +.SH VERSIONS >>>> +Before glibc 2.23, >>>> +these functions obtained the required information by scanning the >>>> .I MemTotal >>>> and >>>> .I MemFree >>>> fields of >>>> .IR /proc/meminfo . >>> >>> Thanks for the patch. But I think it would be better to put >>> all the info into NOTES, rather than splitting some out into >>> VERSIONS. >>> >>>> +.SH CONFORMING TO >>>> +These functions are GNU extensions. >>> >>> And it's good to add this, but let's make it a separate patch. >> >> Hi Michael, >> >> I didn't add that. >> This is one of those times when git provides unreadable diffs. >> Please have a closer look at the diff, >> and also at the rendered output. > > Yes, I see now. > > Still, it would be best to put this piece into NOTES: > > [[ > Before glibc 2.23, > these functions obtained the required information by scanning the > .I MemTotal > Before glibc 2.23, > these functions obtained the required information by scanning the > .I MemTotal > ]] Hi Michael, I've seen you've applied the patch already; maybe by accident? I don't know exactly how you prefer it, so maybe now you can move around the text to NOTES in a new commit. Thanks, Alex > > Thanks, > > Michael >
