Re: [PATCH (2) 21/34] mbstowcs.3: Use sizeof consistently

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Alex,

On 9/4/20 4:45 PM, Alejandro Colomar wrote:
>>From 1b70e7a1da093e4a8e3be79aaed623b21c10e763 Mon Sep 17 00:00:00 2001
> From: Alejandro Colomar <colomar.6.4.3@xxxxxxxxx>
> Date: Thu, 3 Sep 2020 21:51:07 +0200
> Subject: [PATCH 21/34] mbstowcs.3: Use sizeof consistently
> 
> Use ``sizeof`` consistently through all the examples in the following
> way:
> 
> - Use the name of the variable instead of its type as argument for
>   ``sizeof``.
> 
> 	Rationale:
> 	https://www.kernel.org/doc/html/v5.8/process/coding-style.html#allocating-memory

Patch applied.

Cheers,

Michael

> 
> Signed-off-by: Alejandro Colomar <colomar.6.4.3@xxxxxxxxx>
> ---
>  man3/mbstowcs.3 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/man3/mbstowcs.3 b/man3/mbstowcs.3
> index cf650506e..2f9fbc17c 100644
> --- a/man3/mbstowcs.3
> +++ b/man3/mbstowcs.3
> @@ -186,7 +186,7 @@ main(int argc, char *argv[])
>      /* Allocate wide character string of the desired size.  Add 1
>         to allow for terminating null wide character (L\(aq\e0\(aq). */
> 
> -    wcs = calloc(mbslen + 1, sizeof(wchar_t));
> +    wcs = calloc(mbslen + 1, sizeof(*wcs));
>      if (wcs == NULL) {
>          perror("calloc");
>          exit(EXIT_FAILURE);
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/



[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux