Hello Alex, On 9/4/20 4:37 PM, Alejandro Colomar wrote: >>From b43c812d1e129a8d2b34df7624a78baa3bf1273e Mon Sep 17 00:00:00 2001 > From: Alejandro Colomar <colomar.6.4.3@xxxxxxxxx> > Date: Thu, 3 Sep 2020 21:47:45 +0200 > Subject: [PATCH 18/34] insque.3: Use sizeof consistently > > Use ``sizeof`` consistently through all the examples in the following > way: > > - Use the name of the variable instead of its type as argument for > ``sizeof``. > > Rationale: > https://www.kernel.org/doc/html/v5.8/process/coding-style.html#allocating-memory > > Signed-off-by: Alejandro Colomar <colomar.6.4.3@xxxxxxxxx> Thanks. Patch applied. Cheers, Michael > --- > man3/insque.3 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/man3/insque.3 b/man3/insque.3 > index a9fc28550..005ad8cc1 100644 > --- a/man3/insque.3 > +++ b/man3/insque.3 > @@ -182,7 +182,7 @@ new_element(void) > { > struct element *e; > > - e = malloc(sizeof(struct element)); > + e = malloc(sizeof(*e)); > if (e == NULL) { > fprintf(stderr, "malloc() failed\en"); > exit(EXIT_FAILURE); > -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/
