On Tue, Aug 25, 2020 at 2:45 PM Michael Kerrisk (man-pages) <mtk.manpages@xxxxxxxxx> wrote: > > Hi Amir, > > On Mon, 24 Aug 2020 at 10:03, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > > > With fanotify_init(2) flag FAN_REPORT_FID, the group identifies > > filesystem objects by file handles in a single event info record of type > > FAN_EVENT_INFO_TYPE_FID. > > > > We indend to add support for new fanotify_init(2) flags for which the > > group identifies filesystem objects by file handles and add more event > > info record types. > > > > To that end, start by changing the language of the man page to refer > > to a "group that identifies filesystem objects by file handles" instead > > of referring to the FAN_REPORT_FID flag and document the extended event > > format structure in a more generic manner that allows more than a single > > event info record and not only a record of type FAN_EVENT_INFO_TYPE_FID. > > > > Clarify that the object identified by the file handle refers to the > > directory in directory entry modification events. > > > > Remove a note about directory entry modification events and monitoring > > a mount point that I found to be too confusing and out of context. > > If I understand correctly, this patch is just about improving the > description of existing behavior, in preparation for later patches > that describe new behavior (to be added in 5.9), and once you've > revised after Matthew's comments I can apply immediately, right? > That is correct. Thanks, Amir.