On Mon, Aug 24, 2020 at 11:03:24AM +0300, Amir Goldstein wrote: > With fanotify_init(2) flag FAN_REPORT_FID, the group identifies > filesystem objects by file handles in a single event info record of type > FAN_EVENT_INFO_TYPE_FID. > > We indend to add support for new fanotify_init(2) flags for which the > group identifies filesystem objects by file handles and add more event > info record types. > > To that end, start by changing the language of the man page to refer > to a "group that identifies filesystem objects by file handles" instead > of referring to the FAN_REPORT_FID flag and document the extended event > format structure in a more generic manner that allows more than a single > event info record and not only a record of type FAN_EVENT_INFO_TYPE_FID. > > Clarify that the object identified by the file handle refers to the > directory in directory entry modification events. > > Remove a note about directory entry modification events and monitoring > a mount point that I found to be too confusing and out of context. > > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> ... > diff --git a/man7/fanotify.7 b/man7/fanotify.7 > index a7d60b2b9..a7b219168 100644 > --- a/man7/fanotify.7 > +++ b/man7/fanotify.7 > @@ -110,13 +110,11 @@ Two types of events are generated: > events and > .I permission > events. > -Notification events are merely informative > -and require no action to be taken by > -the receiving application with the exception being that the file > -descriptor provided within a generic event must be closed. > -The closing of file descriptors for each event applies only to > -applications that have initialized fanotify without using > -.BR FAN_REPORT_FID > +Notification events are merely informative and require no action to be taken > +by the receiving application with one exception - if a valid file descriptor > +is provided within a generic event, the file descriptor must be closed. Changes read well up until this point. > +File descriptors are not provided with event to applications that have > +created fanotify group so that it identifies filesystem objects by file handles > (see below). Then there's this sentence, which doesn't really read overly smoothly as if there was a few words missing or something. Or, quite possibly it's just me not understanding something? /M
