Hello Elliot, Thanks for looking at the patch. On 7/29/20 6:31 PM, enh wrote: > yeah, the old terminology was so non-obvious that reading through this, > every change seemed like an improvement in clarity. > > my only suggestion would be to consistently use tty_fd and pty_fd in the > function signatures rather than just fd. (the presence or absence of 'p' in > the function name is a clue, i hadn't picked up on that until i > tried rewriting code to use pty/tty rather than master/slave.) Yes, I've made that change now also. > (aside: i was surprised by multiplexor rather than multiplexer, but grep > says man7.org has 2 multiplexors to 1 multiplexer, so lgtm.) Carlos also commented on this. I've changed it (and also in other manual pages where "multiplexor" appeared) Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/
