Re: [PATCH] drop spurious t comment header

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Branden, Mike,

On Fri, 24 Jul 2020 at 02:03, G. Branden Robinson
<g.branden.robinson@xxxxxxxxx> wrote:
>
> At 2020-07-23T17:53:33-0400, Mike Frysinger wrote:
> > From: Mike Frysinger <vapier@xxxxxxxxxxxx>
> >
> > A bunch of pages have this random comment at the start of its header,
> > but most do not.  Just trim it everywhere.
>
> It's pretty misleading to call it "random";

(True.)

> it is a hint to the man
> program to preprocess the man page text through tbl.

Yes, that's my understanding. But I believe that these days it's no
longer needed(?). tbl(1) just gets used as needed, regardless of the
presence of the 't' comment, right?

> This is documented in subsection "Interaction with preprocessors" of
> groff_man(5).
>
> The patch itself might be fine; the first couple of pages it alters
> indeed use no tables, according to the check I ran:
>         grep -l '^\.\s*TS' man[1-8]/*
>
> ...but the comment is certainly not meaningless noise, which is what
> "random" suggests, and I would not characterize the change this in a
> commit message.

See my comments above. For 15 years or at least, I've not paid any
attention to adding the 't' comments when I added tables to pages, and
I do recall anyone reporting ill effects. So, I'm inclined to apply
Mike's patch, but will hold off a moment, in case there's other
feedback.

Cheers,

Michael

-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/



[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux