On 7/6/20 6:31 AM, Jakub Wilk wrote: > THe strfmon(3) change is unrelated to the other changes, and should have > been in a separate patch. Exactly. Bjarni, it's bets if you don't mix unrelated changes tinto the same patch. Thanks, Michael > * Bjarni Ingi Gislason <bjarniig@xxxxxxxxx>, 2020-07-05, 13:40: >> --- a/man3/strfmon.3 >> +++ b/man3/strfmon.3 >> @@ -29,10 +29,10 @@ strfmon, strfmon_l \- convert monetary value to a string >> .B #include <monetary.h> >> .PP >> .BI "ssize_t strfmon(char *" s ", size_t " max ", const char *" format , >> -.B "...);" >> +.IB ... ); > > For variadic function the convention seems to be to format "..." in > bold; see scanf(3), printf(3), wprintf(3) and execv(3) man pages. This > makes sense, because unlike argument names, "..." appear literally in > the function prototypes. > >> -.B const char *" format , "...);" >> +.BI "const char *" format , ... ); > > Ditto. So this line should be: > > .BI "const char *" format ", ...);" > -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/
