Hello Christian, On 9/18/19 9:14 AM, Christian Brauner wrote: > On Wed, Sep 18, 2019 at 08:49:59AM +0200, Michael Kerrisk (man-pages) wrote: >>>> One other piece seems to be missing: the returned file descriptor can >>>> be fed to poll()/select()/epoll and the FD will test as readable when >>>> the child terminates. Right? Did that functionality also land in >>>> kernel 5.2? And did it get implemented as a separate commit, or did >>>> the behavior just fall naturally out of the implementation of pidfd's? >>>> Let me know the details, and I will craft a patch. >>> >>> It landed in 5.3. The relevant commit is: >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b53b0b9d9a613c418057f6cb921c2f40a6f78c24 >>> and belongs to the following merge: >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5450e8a316a64cddcbc15f90733ebc78aa736545 >> >> Thanks for that info. One other questions springs to mind. >> I haven't looked at the source or tried testing this, >> but can anything actually be read() from a PIDFD? Presumably, > > We had discussed this but decided to not implement this right away. > Mainly, because we did not have a clear picture what the semantics > should be. But it is something that we will probably want in the > future... That makes sense. A further question... We now have three ways of getting a process file descriptor [*]: open() of /proc/PID pidfd_open() clone()/clone3() with CLONE_PIDFD I thought the FD was supposed to be equivalent in all three cases. However, if I try (on kernel 5.3) poll() an FD returned by opening /proc/PID, poll() tells me POLLNVAL for the FD. Is that difference intentional? (I am guessing it is not.) Thanks, Michael [*} By the way, going forward, can we call these things "process FDs", rather than "PID FDs"? The API names are what they are, an that's okay, but these just as we have socket FDs that refer to sockets, directory FDs that refer to directories, and timer FDs that refer to timers, and so on, these are FDs that refer to *processes*, not "process IDs". It's a little thing, but I think the naming better, and it's what I propose to use in the manual pages. -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/
