Re: Quick fix for syscall man page

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Walter,

On Mon, 9 Sep 2019 at 11:08, walter harms <wharms@xxxxxx> wrote:
>
>
>
> Am 09.09.2019 10:52, schrieb Michael Kerrisk (man-pages):
> > [Adding Adam Borowski in CC, since he wrote the riscv text back at the
> > start of 2018, andand he may have a comment.]
> >
> > On Thu, 5 Sep 2019 at 18:35, Florin Blanaru <florin.blanaru96@xxxxxxxxx> wrote:
> >>
> >> http://man7.org/linux/man-pages/man2/syscall.2.html
> >>
> >> In the first table, for the riscv Arch/ABI, the instruction should be
> >> ecall instead of scall.
> >>
> >> According the official manual, the instruction has been renamed.
> >> https://content.riscv.org/wp-content/uploads/2017/05/riscv-spec-v2.2.pdf
> >>
> >> "The SCALL and SBREAK instructions have been renamed to ECALL and
> >> EBREAK, re-spectively. Their encoding and functionality are
> >> unchanged."
> >
>
> Maybe it would be helpful to add a "footnote" that this is a rename only.
> Otherwise people may get confused.

Yes, perhaps that would be helpful. I updated the patch to be as below.

Thanks!

Michael

diff --git a/man2/syscall.2 b/man2/syscall.2
index 77e6bccdd..53118c297 100644
--- a/man2/syscall.2
+++ b/man2/syscall.2
@@ -196,7 +196,7 @@ mips        syscall v0      v0      v1      a3      1, 6
 nios2  trap    r2      r2      -       r7
 parisc ble 0x100(%sr2, %r0)    r20     r28     -       -
 powerpc        sc      r0      r3      -       r0      1
-riscv  scall   a7      a0      a1      -
+riscv  ecall   a7      a0      a1      -       7
 s390   svc 0   r1      r2      r3      -       3
 s390x  svc 0   r1      r2      r3      -       3
 superh trap #0x17      r3      r0      r1      -       4, 6
@@ -298,6 +298,11 @@ in the system call interface, even if it is
defined in the System V ABI.
 .in
 .ft P
 \}
+.IP [7]
+On riscv, the
+.I ecall
+instruction was formerly named
+.IR scall .
 .PP
 The second table shows the registers used to pass the system call arguments.
 .if t \{\





-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/



[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux