Hello Bjarni,
On 1/26/19 10:34 PM, Bjarni Ingi Gislason wrote:
> Use a single-font-style macro (".B", ".I") for a single argument.
>
> Separate the section part from the name of a manual.
>
> The output from "nroff" and "groff" is unchanged, except for the style
> of the section part of some names of manuals.
But some of these changes are incorrect. See below.
>
> Signed-off-by: Bjarni Ingi Gislason <bjarniig@xxxxxxxxx>
> ---
> man2/set_mempolicy.2 | 2 +-
> man2/set_thread_area.2 | 2 +-
> man2/seteuid.2 | 4 ++--
> man2/setfsgid.2 | 2 +-
> man2/setfsuid.2 | 2 +-
> man2/setns.2 | 14 +++++++-------
> man2/setsid.2 | 2 +-
> man2/setuid.2 | 2 +-
> man2/setxattr.2 | 2 +-
> 9 files changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/man2/set_mempolicy.2 b/man2/set_mempolicy.2
> index 7a26f674d..8fd0922ab 100644
> --- a/man2/set_mempolicy.2
> +++ b/man2/set_mempolicy.2
> @@ -81,7 +81,7 @@ argument must specify one of
> .BR MPOL_INTERLEAVE ,
> .BR MPOL_PREFERRED ,
> or
> -.BR MPOL_LOCAL
> +.B MPOL_LOCAL
> (which are described in detail below).
> All modes except
> .B MPOL_DEFAULT
> diff --git a/man2/set_thread_area.2 b/man2/set_thread_area.2
> index efa6a49cc..89d356de8 100644
> --- a/man2/set_thread_area.2
> +++ b/man2/set_thread_area.2
> @@ -121,7 +121,7 @@ and
> .I seg_not_present
> are set to 1 and all of the other fields are 0.
> If an "empty" descriptor is passed to
> -.BR set_thread_area,> +.B set_thread_area,
Should be:
.BR set_thread_area ,
> the corresponding TLS entry will be cleared.
> See BUGS for additional details.
> .PP
> diff --git a/man2/seteuid.2 b/man2/seteuid.2
> index 24662e178..d41347087 100644
> --- a/man2/seteuid.2
> +++ b/man2/seteuid.2
> @@ -86,7 +86,7 @@ The target user or group ID is not valid in this user namespace.
> In the case of
> .BR seteuid ():
> the calling process is not privileged (does not have the
> -.BR CAP_SETUID
> +.B CAP_SETUID
> capability in its user namespace) and
> .I euid
> does not match the current real user ID, current effective user ID,
> @@ -95,7 +95,7 @@ or current saved set-user-ID.
> In the case of
> .BR setegid ():
> the calling process is not privileged (does not have the
> -.BR CAP_SETGID
> +.B CAP_SETGID
> capability in its user namespace) and
> .I egid
> does not match the current real group ID, current effective group ID,
> diff --git a/man2/setfsgid.2 b/man2/setfsgid.2
> index f22183423..199d13066 100644
> --- a/man2/setfsgid.2
> +++ b/man2/setfsgid.2
> @@ -113,7 +113,7 @@ the same value makes it impossible to directly determine
> whether the call succeeded or failed.
> Instead, the caller must resort to looking at the return value
> from a further call such as
> -.IR setfsgid(\-1)
> +.IR setfsgid (\-1)
Should not be changed.
> (which will always fail), in order to determine if a preceding call to
> .BR setfsgid ()
> changed the filesystem group ID.
> diff --git a/man2/setfsuid.2 b/man2/setfsuid.2
> index b5842a69b..90253a04d 100644
> --- a/man2/setfsuid.2
> +++ b/man2/setfsuid.2
> @@ -121,7 +121,7 @@ the same value makes it impossible to directly determine
> whether the call succeeded or failed.
> Instead, the caller must resort to looking at the return value
> from a further call such as
> -.IR setfsuid(\-1)
> +.IR setfsuid (\-1)
Should not be changed.
That you have mixed in multiple changes in various patches, some
of which are useful, others of which are less desirable from my point
of view (because of churn), and then some of the changes are wrong,
makes it quite difficult for me to use this patch series.
Thanks,
Michael
PS Please don't send me more patches just yet, while I work
out what to do with the existing set.
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
