> -----Original Message----- > From: Ricardo Biehl Pasquali [mailto:pasqualirb@xxxxxxxxx] > Sent: Tuesday, February 26, 2019 10:57 AM > To: Michael Kerrisk (man-pages) <mtk.manpages@xxxxxxxxx>; Keller, Jacob E > <jacob.e.keller@xxxxxxxxx> > Cc: linux-man <linux-man@xxxxxxxxxxxxxxx> > Subject: Re: [PATCH] socket.7: Add description of SO_SELECT_ERR_QUEUE > > Ok, let me rewrite everything: > > SO_SELECT_ERR_QUEUE makes poll adding POLLPRI when POLLERR > event is returned. It does not affect wake up. > > Background: The flag was added when waking up on POLLERR > required requesting POLLIN or POLLPRI. After the commit > 6e5d58fdc9bedd0255a8 ("skbuff: Fix not waking applications > when errors are enqueued"), introduced in Linux 4.16, > waking up on POLLERR does not require requesting other > events. > > One more thing, the flag's effect seems to apply only for > some types of socket (perhaps only datagram ones?). Jacob? > <https://git.kernel.org/pub/scm/linux/kernel/git/davem/ > net.git/diff/?h=7d4c04fc1700>. > I don't believe it was intended to only work on datagram sockets, but I only ever tested it using them (for Tx timestamps). > The intention is to have a short and simple description that > explain it all. The description looks good to me. Thanks, Jake > > pasquali
