Re: [PATCH] shmctl.2, semctl.2, msgctl.2: add STAT_ANY commands

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/22/2018 03:40 PM, Joe Lawrence wrote:
> On 06/22/2018 03:26 PM, Davidlohr Bueso wrote:
>> On Fri, 22 Jun 2018, Joe Lawrence wrote:
>>
>>> The linux kernel has added STAT_ANY variants to the shmctl(), semctl(),
>>> and msgctl() shared memory functions.  Add descriptions for these new
>>> cmd values.
>>>
>>> The text is adopted directly from Davidlohr Bueso's <dave@xxxxxxxxxxxx>
>>> upstream linux kernel commits:
>>>
>>>  ipc/shm: introduce shmctl(SHM_STAT_ANY)
>>>  ipc/sem: introduce semctl(SEM_STAT_ANY)
>>>  ipc/msg: introduce msgctl(MSG_STAT_ANY)
>>>
>>> [ ... snip ... ]
>>>
>> I had written one after this stuff was merged upstream:
>>
>> Please see https://lkml.org/lkml/2018/3/20/715
>>
> 
> Hi Davidlohr,
> 
> So an update was already written, then NACK to my repost of your own
> words from the kernel commit msgs.
> 
> Your version on lkml looks good, though I have one question about this hunk:
> 
>> diff --git a/man2/msgctl.2 b/man2/msgctl.2
>> index df74c750457a..31b1a1f12fb0 100644
>> --- a/man2/msgctl.2
>> +++ b/man2/msgctl.2
>> ...
>> @@ -222,10 +223,23 @@ Return a
>>  structure as for
>>  .BR IPC_STAT .
>>  However, the
>> -.I msqid
>> +.I msgid
>>  argument is not a queue identifier, but instead an index into
>>  the kernel's internal array that maintains information about
>>  all message queues on the system.
> 
> According to the rest of the manual page and indeed sys/msg.h, this
> argument is referred to as "msgid" and not "msqid".  Was this meant to
> have been modified?
> 
> 

I just noticed that neither (my or Davidlohr's) proposed update has made
it into the docs for the stat_any commands.

If I remember correctly they are effectively the same, so either would
suffice.

Thanks,

-- Joe



[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux