Re: [PATCH] rename.2: Add kernel versions for RENAME_NOREPLACE support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> Lucas Werkmeister <mail@xxxxxxxxxxxxxxxxxxx> hat am 14. September 2018 um
> 00:37 geschrieben:
> 
> 
> The RENAME_NOREPLACE flag was added with the initial release of the
> renameat2 syscall in Linux 3.15, but support for most filesystems was
> only added in later versions, and some may still not support it.
> 
> Signed-off-by: Lucas Werkmeister <mail@xxxxxxxxxxxxxxxxxxx>
> ---
> 
> Notes:
>     This list gets rather unwieldy with Linux 4.9, but I’m not sure what
>     the best way to avoid that is…
> 

Hello,
i would say that your commit message is better that the wording below.

ENAME_NOREPLACE is available since Linux 3.15, but support for most filesystems
was
only added in later versions.

IMHO going into details makes no sence. One example like: ext4 supports it since
3.15 also
is ok but everything else is beyond what can be done otherwise you would need to
change
that sentence everytime someone adds a new FS or adds that feature.

just my 2 cents

re,
 wh


>  man2/rename.2 | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/man2/rename.2 b/man2/rename.2
> index 53b26b589..03d542939 100644
> --- a/man2/rename.2
> +++ b/man2/rename.2
> @@ -209,6 +209,21 @@ already exists.
>  .B RENAME_NOREPLACE
>  can't be employed together with
>  .BR RENAME_EXCHANGE .
> +.IP
> +.B RENAME_NOREPLACE
> +requires support from the underlying filesystem.
> +Among the filesystems that provide that support are
> +ext4 (since Linux 3.15),
> +.\" ext4: commit 0a7c3937a1f23f8cb5fc77ae01661e9968a51d0c
> +btrfs, shmem and cifs (since Linux 3.17),
> +.\" btrfs: commit 80ace85c915d0f41016f82917218997b72431258
> +.\" shmem: commit 3b69ff51d087d265aa4af3a532fc4f20bf33e718
> +.\" cifs: commit 7c33d5972ce382bcc506d16235f1e9b7d22cbef8
> +and affs, bfs, exofs, ext2, hfs, hfsplus, jffs2, jfs, logfs, minix, msdos,
> +nilfs2, omfs, reiserfs, sysvfs, ubifs, udf, ufs, vfat,
> +hugetlbfs, ramfs, and bpf (since Linux 4.9).
> +.\" local filesystems: commit f03b8ad8d38634d13e802165cc15917481b47835
> +.\" libfs: commit e0e0be8a835520e2f7c89f214dfda570922a1b90
>  .TP
>  .BR RENAME_WHITEOUT " (since Linux 3.18)"
>  .\" commit 0d7a855526dd672e114aff2ac22b60fc6f155b08
> -- 
> 2.19.0
> 



[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux