2018-04-11 16:44 UTC+0100 ~ Quentin Monnet <quentin.monnet@xxxxxxxxxxxxx> > 2018-04-10 09:58 UTC-0700 ~ Yonghong Song <yhs@xxxxxx> >> On 4/10/18 7:41 AM, Quentin Monnet wrote: >>> Add documentation for eBPF helper functions to bpf.h user header file. >>> This documentation can be parsed with the Python script provided in >>> another commit of the patch series, in order to provide a RST document >>> that can later be converted into a man page. >>> >>> The objective is to make the documentation easily understandable and >>> accessible to all eBPF developers, including beginners. >>> >>> This patch contains descriptions for the following helper functions: >>> >>> Helpers from Lawrence: >>> - bpf_setsockopt() >>> - bpf_getsockopt() >>> - bpf_sock_ops_cb_flags_set() >>> >>> Helpers from Yonghong: >>> - bpf_perf_event_read_value() >>> - bpf_perf_prog_read_value() >>> >>> Helper from Josef: >>> - bpf_override_return() >>> >>> Helper from Andrey: >>> - bpf_bind() >>> >>> Cc: Lawrence Brakmo <brakmo@xxxxxx> >>> Cc: Yonghong Song <yhs@xxxxxx> >>> Cc: Josef Bacik <jbacik@xxxxxx> >>> Cc: Andrey Ignatov <rdna@xxxxxx> >>> Signed-off-by: Quentin Monnet <quentin.monnet@xxxxxxxxxxxxx> >>> --- > [...] > > Thanks Yonghong for the review! > > I have a favor to ask of you. I got a bounce for Kaixu Xia's email > address, and I don't know what alternative email address I could use. I > CC-ed to have a review for helper bpf_perf_event_read() (in patch 6 of > this series), which is rather close to bpf_perf_event_read_value(). > Would you mind having a look at that one too, please? The description is > not long. Well I read again the description I wrote, and actually the one for bpf_perf_evnet_read() is nearly a subset of the one for perf_event_read_value(). So the same comments that you raised earlier apply, there's probably nothing more to review. But if you notice that some important info is missing for bpf_perf_event_read(), I'm interested too! Quentin -- To unsubscribe from this list: send the line "unsubscribe linux-man" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
