Re: [PATCH v3 1/1] s390_sthyi.2: New page for s390-specific s390_sthyi(2)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





在 2017/12/12 12:22, Michael Kerrisk (man-pages) 写道:
Hello QingFeng,

On 12 December 2017 at 03:40, QingFeng Hao <haoqf@xxxxxxxxxxxxxxxxxx> wrote:

在 2017/12/12 3:00, Michael Kerrisk (man-pages) 写道:
On 11/23/2017 02:45 PM, QingFeng Hao wrote:
Signed-off-by: QingFeng Hao <haoqf@xxxxxxxxxxxxxxxxxx>
---
Thank you for this page, QingFeng!

I've applied your patch, and made a few tweaks. You may want to look
at the revised version in Git.
Michael,
Really appreciate your wonderful changes on this man-page, which made it
much better!
You're welcome!

Just one question about "*buffer" in section "RETURN VALUE"
that why using "*buffer" instead of "buffer" here? Is it meant to indicate
that
it's a pointer?
Yes, that's the intention. I could also have written something like
"the location pointed to by buffer", but "*buffer" seemed more
compact.

Reflecting on this further, I wonder about changing the name of that
argument in the man page from "buffer" to (say) "resp_buffer". The
problem is that the term "buffer" (which I realize is what is used in
the kernel source code) is very generic. A more descriptive name in
the man page would be helpful I think. (I even think it would be more
helpful in the source code, but that's another story.) What do you
think?
I agree to use resp_buffer to reflect that it's for the response. Thanks!

Cheers,

Michael


--
Regards
QingFeng Hao

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux