On Thu, Nov 30, 2017 at 01:21:26PM +0000, Jorgen S. Hansen wrote: > > On Nov 30, 2017, at 12:21 PM, Stefan Hajnoczi <stefanha@xxxxxxxxxx> wrote: Thanks for the quick review! I forgot to ask you: Is SOCK_DGRAM reliable and in-order over VMCI? > > +.PP > > +Valid socket types are > > +.B SOCK_STREAM > > +and > > +.B SOCK_DGRAM . > > The space here results in a space between SOCK_DGRAM and the “.” in the formatted text. Is that intentional? I haven't figured out the groff syntax to avoid the space :(. Any ideas? > > +.PP > > +There are several special addresses: > > +.B VMADDR_CID_ANY > > +(-1U) > > +means any address for binding; > > +.B VMADDR_CID_HYPERVISOR > > We use VMADDR_CID_HYPERVISOR for communicating with services in the hypervisor, so you could describe this as “an address reserved for services built into the hypervisor”. Will fix. > > +.SH VERSIONS > > +Support for VMware has been available since Linux 3.9. KVM (virtio) is > > VMware (VMCI) for clarity. Will fix. > Apart from the nits, this looks great. Please let me know if there are any other topics that we should cover in the man page.
Attachment:
signature.asc
Description: PGP signature
