Re: [PATCH] pkey_alloc.2: Fix argument order

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/07/2017 01:23 PM, Breno Leitao wrote:
> Currently pkey_alloc() syscall has two arguments, and the very first
> argument is still not supported as in kernel 4.14-rc8 and should be set
> to zero, as showed in the following syscall implementation:
> 
> 	SYSCALL_DEFINE2(pkey_alloc, unsigned long, flags, ...)
> 	{
> 		int pkey;
> 		int ret;
> 
> 		/* No flags supported yet. */
> 		if (flags)
> 			return -EINVAL;
> 
> This behaviour is also documented correctly in the kernel documentation
> as Documentation/x86/protection-keys.txt
> 
> The second argument is the one that should specify the page access
> rights.
> 
> This patch fixes the manpage to describe how the code behaves.

Thanks, Breno. Patch applied.

Cheers,

Michael


> Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx>
> ---
>  man2/pkey_alloc.2 | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/man2/pkey_alloc.2 b/man2/pkey_alloc.2
> index 8e701961c..858f64ce6 100644
> --- a/man2/pkey_alloc.2
> +++ b/man2/pkey_alloc.2
> @@ -40,6 +40,12 @@ allocates a protection key (pkey) and allows it to be passed to
>  The
>  .BR pkey_alloc ()
>  .I flags
> +argument is still not supported and should be set to "0".
> +.PP
> +The
> +.BR pkey_alloc ()
> +.I access_rights
> +.BR
>  argument may contain zero or more disable operations:
>  .TP
>  .B PKEY_DISABLE_ACCESS
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux