Re: [PATCH 0/4] crypt.3: documented "rounds" parameter for SHA-* algorithms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Konstantin,

On 09/03/2017 06:16 PM, Konstantin Shemyak wrote:
> SHA-256 and SHA-512 based encryption algorithms support passing
> number of hashing rounds in the salt string, like:
> 
> crypt("password", "$5$rounds=100000$saltsaltsalt")
> 
> This was present since introduction of SHA-*-based algorithms in the
> glibc commit c3266dc0d85ed519ff40d1738aadf7b1280af3ba.
> 
> The parameter is explained. Minor wording and formatting fixes done.
> 
> Konstantin Shemyak (4):
>   crypt.3: wfix: encryption is not done with SHA-xxx, but with a
>     function based on SHA-xxx.
>   crypt.3: ffix: added missing formatting
>   crypt.3: wfix: clarified that ending of the salt string with '$' is
>     optional
>   crypt.3: Added description of previously undocumented 'rounds'
>     parameter
> 
>  man3/crypt.3 | 30 +++++++++++++++++++++++-------
>  1 file changed, 23 insertions(+), 7 deletions(-)

In general the patch series looks good, but I need some more
supporting information for the commit message and for checking details.
See comments on individual patches, in following mails.

Cheers,

Michael


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux