Re: [PATCH] perf_event_open.2: Add a note that dyn_size is omitted if size == 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 3 Jul 2016, Keno Fischer wrote:

> The perf_output_sample_ustack in kernel/events/core.c only writes a
> single 64 bit word
> if it can't dump the user registers. From the current version of the
> man page, I would
> have expected two 64 bit words (one for size, one for dyn_size). Change the man
> page to make this behavior explicit.
> 
> This is my first man-pages patch, please let me know if I should do
> anything else.

Overall it looks fine, to me at least. 

It's sometimes also nice to have the commit where the behavior was first 
introuduced mentioned, but in this case since the behavior hasn't changed 
since introduction that's probably not necessary.

I'm fine with this being taken directly.  (not sure if I should kick in a 
reviewed-by or some such tag (?)).
 
I'm slowly catching up on the backlog of perf_event_open.2 updates, 
hopefully I'll start sending those in soon.

Vince
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux