Re: [PATCH 1/2] mount.2: document MS_REC and shared subtree flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 12, 2016 at 10:36:00AM +0200, Florian Weimer wrote:
> On 05/12/2016 09:17 AM, Omar Sandoval wrote:
> > +.BR MS_PRIVATE " (since Linux 2.6.15)"
> > +Set the mount propagation on this mountpoint to private. Mounts will not
> > +propagate to or from replicated subtrees.
> > +When used, this must be the only flag in
> > +.IR mountflags .
> 
> Is the last sentence actually true?  Further down, your patch mentions
> combining MS_PRIVATE with other flags.
> 
> Thanks,
> Florian

Yeah, you're right, I documented that it can be combined with MS_REC,
and looking closer, it can also be combined with MS_SILENT. Even more
confusing is that there's a bunch of flags that we'll end up ignoring:

	flags &= ~(MS_NOSUID | MS_NOEXEC | MS_NODEV | MS_ACTIVE | MS_BORN |
		   MS_NOATIME | MS_NODIRATIME | MS_RELATIME| MS_KERNMOUNT |
		   MS_STRICTATIME);

So any of those flags are ignored, MS_REC and MS_SILENT are valid, and
anything else is an error. I'll try to come up with an explanation that
makes sense, but it's a bit of a mess.

-- 
Omar
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux