Re: [PATCH] nan.3: ATTRIBUTES: Note functions that are thread-safe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4 February 2015 at 10:52, Ma Shimiao <mashimiao.fnst@xxxxxxxxxxxxxx> wrote:
> Hi Michael,
>
> On 02/04/2015 05:31 PM, Michael Kerrisk (man-pages) wrote:
>> Hello Ma Shimiao,
>>
>> On 4 February 2015 at 09:56, Ma Shimiao <mashimiao.fnst@xxxxxxxxxxxxxx> wrote:
>>> Hi Michael,
>>> On 02/04/2015 03:53 PM, Michael Kerrisk (man-pages) wrote:
>>>> On 02/04/2015 07:45 AM, Ma Shimiao wrote:
>>>>> The markings match glibc markings.
>>>>
>>>> Hi Ma Shimiao.
>>>>
>>>> Patch applied. Thanks! But I had to fix up the formatting a little.
>>>> Please do check the rendered version of each page that is patched.
>>>
>>> Sorry, I can't find out what's wrong with the formatting.
>>> Could you tell me what's wrong with the formatting?
>>> Or you send me your fixed version, let me find out the difference.
>>> Thanks a lot.
>>
>> Sorry -- of course I should have done that. See
>> http://git.kernel.org/cgit/docs/man-pages/man-pages.git/commit/?h=mt_attributes&id=f83348c6b12fee3f016449cb2b1eee7dd901af6c
>> That just fixes the formatting so that we don't get large whitespaces
>> in the left hand column of the table.
> Thanks for fixing.
> But, could you tell me which editor do you use to review the formatting?

Just man(1). Before my fix thtable looks like this:

       ┌────────────────────┬───────────────┬────────────────┐
       │Interface           │ Attribute     │ Value          │
       ├────────────────────┼───────────────┼────────────────┤
       │nan(),      nanf(), │ Thread safety │ MT-Safe locale │
       │nanl()              │               │                │
       └────────────────────┴───────────────┴────────────────┘

After commit 76e92de6fd, it looks like

       ┌──────────────────────┬───────────────┬────────────────┐
       │Interface             │ Attribute     │ Value          │
       ├──────────────────────┼───────────────┼────────────────┤
       │nan(), nanf(), nanl() │ Thread safety │ MT-Safe locale │
       └──────────────────────┴───────────────┴────────────────┘

The difference that I was concerned about is in row 2, column 1.

Cheers,

Michael


>>>>
>>>> Thanks,
>>>>
>>>> Michael
>>>>
>>>>
>>>>> Signed-off-by: Ma Shimiao <mashimiao.fnst@xxxxxxxxxxxxxx>
>>>>> ---
>>>>>  man3/nan.3 | 14 ++++++++++++++
>>>>>  1 file changed, 14 insertions(+)
>>>>>
>>>>> diff --git a/man3/nan.3 b/man3/nan.3
>>>>> index 6c9deb6..da04cba 100644
>>>>> --- a/man3/nan.3
>>>>> +++ b/man3/nan.3
>>>>> @@ -72,6 +72,20 @@ selects one.
>>>>>  On other systems it may do nothing.
>>>>>  .SH VERSIONS
>>>>>  These functions first appeared in glibc in version 2.1.
>>>>> +.SH ATTRIBUTES
>>>>> +For an explanation of the terms used in this section, see
>>>>> +.BR attributes (7).
>>>>> +.TS
>>>>> +allbox;
>>>>> +lb lb lb
>>>>> +l l l.
>>>>> +Interface   Attribute       Value
>>>>> +T{
>>>>> +.BR nan (),
>>>>> +.BR nanf (),
>>>>> +.BR nanl ()
>>>>> +T}  Thread safety   MT-Safe locale
>>>>> +.TE
>>>>>  .SH CONFORMING TO
>>>>>  C99, POSIX.1-2001.
>>>>>  See also IEC 559 and the appendix with
>>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> Ma Shimiao
>>> Development Dept.I
>>> Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
>>
>>
>>
>
>
> --
> Ma Shimiao
> Development Dept.I
> Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)



-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
��.n��������+%������w��{.n�����{��f��)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥





[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux