Hi Vince, On 01/23/2015 06:58 PM, Vince Weaver wrote: > > I noticed you were adding git commit references to the various > Linux version markers. > > This adds git commit references for all Linux kernel version > notes in perf_event_open.2 Thanks for this. It's really helpful! I've applied this patch, but see the comment below about two pieces that I backed out of the patch. > Signed-off-by: Vince Weaver <vincent.weaver@xxxxxxxxx> > > diff --git a/man2/perf_event_open.2 b/man2/perf_event_open.2 > index 27885f3..e91ef21 100644 > --- a/man2/perf_event_open.2 > +++ b/man2/perf_event_open.2 [...] > +Refreshing an event group leader refreshes all siblings, > +and refreshing with a parameter of 0 enables infinite refresh. > +This behavior is unsupported and should not be relied on. > +.\" See https://lkml.org/lkml/2011/5/24/337 The piece above really should be a separate patch. I've backed this piece of the patch out. Could you send me another patch with this change and a suitable commit message. [...] > -In older Linux 2.6 versions, > -refreshing an event group leader refreshed all siblings, > -and refreshing with a parameter of 0 enabled infinite refresh. > -This behavior is unsupported and should not be relied on. The piece above really should be a separate patch (assuming it was intentional). I've backed this piece of your patch out. Assuming you intended this change, could you send me another patch with this change and a suitable commit message. I'd prefer to keep this historical info in the page, with a statement about when (which kernel version) it ceased to be true. But if that's too troublesome, I will also just take a patch that deletes the text. Thanks, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/ -- To unsubscribe from this list: send the line "unsubscribe linux-man" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
