On 01/23/2015 06:29 PM, JWP wrote:
> Hello Michael,
>
> I split the patch[V2] and added more details as requested.
> Is there still something wrong with my submission?
>
> Thank you
> Have a great weekend
Sorry, William. I have had not much chance to look at these yet,
and I was hoping someone else might review. I'll take a look
at some of them soon.
Cheers,
Michael
> On 01/18/2015 06:02 AM, Michael Kerrisk (man-pages) wrote:
>> Hello William,
>>
>> On 01/18/2015 01:34 AM, JWP wrote:
>>> Remove references to /usr/share/zoneinfo/{localtime,posixrules}
>>> as they are not used.
>>>
>>> Add information on invalid TZ values.
>>> Add information on a TZ filespec that omits the colon.
>>> Add information on system timezone configuration.
>>> Add an ENVIRONMENT section.
>>> Update the FILES section.
>>
>> Thanks for submitting this, but it's very hard for me to use
>> this patch in the submitted form. Specifically:
>>
>> * It groups a number of unrelated changes into a single patch.
>> Could you break each logical change into a separate commit/patch
>> please. This would allow me (and others) to independently review
>> each piece and decide whether it should be applied.
>>
>> * Please make the patch descriptions more than just a statement of
>> *what* you changed. Please explain what the problem was, and why
>> you fixed it as you did, and where it makes sense add pointers
>> to information that supports you reasoning.
>>
>> Thanks,
>>
>> Michael
>>
>>
>>> Signed-off-by: J William Piggott <elseifthen@xxxxxxx>
>>> ---
>>>
>>> The following changes since commit dc70d1eaef1643ae48a9b67fcde0cd0b59bf1f20:
>>>
>>> ld.so.8: tfix (2015-01-16 15:07:43 +0100)
>>>
>>> are available in the git repository at:
>>>
>>> git@xxxxxxxxxx:jwpi/man-pages.git tzset
>>>
>>> for you to fetch changes up to 13f95862d88f041ce652ff846b2706c3d1fccf6a:
>>>
>>> tzset.3: correct file paths and TZ use (2015-01-17 16:51:42 -0500)
>>>
>>>
>>> man3/tzset.3 | 81 +++++++++++++++++++++++++++---------------------------------
>>> 1 file changed, 37 insertions(+), 44 deletions(-)
>>>
>>> diff --git a/man3/tzset.3 b/man3/tzset.3
>>> index c1c98e1..1058d2c 100644
>>> --- a/man3/tzset.3
>>> +++ b/man3/tzset.3
>>> @@ -30,7 +30,7 @@
>>> .\" Modified 2001-11-13, aeb
>>> .\" Modified 2004-12-01 mtk and Martin Schulze <joey@xxxxxxxxxxxx>
>>> .\"
>>> -.TH TZSET 3 2014-08-19 "" "Linux Programmer's Manual"
>>> +.TH TZSET 3 2015-01-16 "" "Linux Programmer's Manual"
>>> .SH NAME
>>> tzset, tzname, timezone, daylight \- initialize time conversion information
>>> .SH SYNOPSIS
>>> @@ -75,15 +75,14 @@ the year when daylight saving time applies).
>>> .PP
>>> If the
>>> .B TZ
>>> -variable does not appear in the environment, the \fItzname\fP
>>> -variable is initialized with the best approximation of local wall clock
>>> -time, as specified by the
>>> -.BR tzfile (5)-format
>>> -file \fIlocaltime\fP
>>> -found in the system timezone directory (see below).
>>> -(One also often sees
>>> -.I /etc/localtime
>>> -used here, a symlink to the right file in the system timezone directory.)
>>> +variable does not appear in the environment, the system timezone is used.
>>> +The system timezone is configured by copying, or linking, a file in the
>>> +.BR tzfile "(5) format to"
>>> +.IR /etc/localtime .
>>> +A timezone database of these files may be located in the system
>>> +timezone directory (see the \fBFILES\fP section below).
>>> +
>>> +
>>> .PP
>>> If the
>>> .B TZ
>>> @@ -118,7 +117,7 @@ The second format is used when there is daylight saving time:
>>> .I std offset dst [offset],start[/time],end[/time]
>>> .RE
>>> .sp
>>> -There are no spaces in the specification.
>>> +There are no spaces in either specification.
>>> The initial \fIstd\fP and
>>> \fIoffset\fP specify the standard timezone, as described above.
>>> The \fIdst\fP string and \fIoffset\fP specify the name and offset for the
>>> @@ -170,47 +169,41 @@ from a file:
>>> :[filespec]
>>> .RE
>>> .sp
>>> -If the file specification \fIfilespec\fP is omitted, the timezone
>>> -information is read from the file
>>> -.I localtime
>>> -in the system timezone directory, which nowadays usually is
>>> -.IR /usr/share/zoneinfo .
>>> -This file is in
>>> +If the file specification \fIfilespec\fP is omitted, or its value cannot
>>> +be interpreted, Coordinated Universal Time (UTC) is used. A correct
>>> +\%\fIfilespec\fP will be a path pointing to a file in the
>>> .BR tzfile (5)
>>> -format.
>>> -If \fIfilespec\fP is given, it specifies another
>>> -.BR tzfile (5)-format
>>> -file to read the timezone information from.
>>> -If \fIfilespec\fP does not begin with a \(aq/\(aq, the file specification is
>>> -relative to the system timezone directory.
>>> +format. A timezone database of these files may be located in the system
>>> +timezone directory (see the \fBFILES\fP section below). If
>>> +\fIfilespec\fP does not begin with a \(aq/\(aq, the file specification
>>> +is relative to the system timezone directory. If the colon is omitted
>>> +each of the above three \fBTZ\fP formats will be tried in order.
>>> .PP
>>> Here's an example, once more for New Zealand:
>>> .nf
>>>
>>> TZ=":Pacific/Auckland"
>>> .fi
>>> +.SH ENVIRONMENT
>>> +.TP
>>> +.B TZ
>>> +.RB If \ TZ
>>> +is set, its value takes precedence over the system configured timezone.
>>> +.TP
>>> +.B TZDIR
>>> +.RB If \ TZDIR
>>> +is set, its value takes precedence over the system configured timezone
>>> +database directory path.
>>> .SH FILES
>>> -Under glibc,
>>> -the system timezone directory is determined using the
>>> -.BR TZDIR
>>> -the environment variable.
>>> -If
>>> -.BR TZDIR
>>> -is not set, the default depends on the system setup, but is normally
>>> -.IR /usr/share/zoneinfo .
>>> -.LP
>>> -This timezone directory contains the files
>>> -
>>> -.nf
>>> - localtime local timezone file
>>> - posixrules rules for POSIX-style TZ's
>>> -.fi
>>> -.LP
>>> -Often,
>>> -.I /etc/localtime
>>> -is a symbolic link to the file
>>> -.I localtime
>>> -or to the correct timezone file in the system timezone directory.
>>> +.TP
>>> +.B /etc/localtime
>>> +The system timezone file.
>>> +.TP
>>> +.B /usr/share/zoneinfo/
>>> +The system timezone database directory.
>>> +.PP
>>> +Above are the current standard file locations, but they are
>>> +configurable when glibc is compiled.
>>> .SH CONFORMING TO
>>> SVr4, POSIX.1-2001, 4.3BSD.
>>> .SH NOTES
>>>
>>
>>
>
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
