On Mon, Apr 28, 2014 at 08:12:30PM +0200, Carsten Andrich wrote: > Am Montag, den 28.04.2014, 13:28 -0400 schrieb Neil Horman: > > Rather than 'lingernig' perhaps more exact language to indicate that positive > > action is required from the application. Perhaps: > > > > Packets in the WRONG_FORMAT state block the kernel from sending it and subsequent > > packets on the ring. Packet in the WRONG_FORMAT state must be moved to the > > AVAILABLE or SEND_REQUEST state (after correcting format errors), so that the > > next application call to send() properly transmits the frame. > > Thanks for the suggestion! I incorporated it into the following updated > PACKET_LOSS description: > When a malformed packet is encountered on a transmit ring, the default > is to reset its tp_status to TP_STATUS_WRONG_FORMAT and abort the > transmission immediately. The malformed packet blocks itself and > subsequent enqueued packets from being sent. The format error must be > fixed, the associated tp_status reset to TP_STATUS_SEND_REQUEST and the > transmission process restarted via send(2). However, if PACKET_LOSS is > set, any malformed packet will be skipped, its tp_status reset to > TP_STATUS_AVAILABLE, and the transmission process continued. > > IMHO this should go into the PACKET_TX_RING description, but I'd like to > defer that until I have a little more spare time on my hands, so I can > tackle the entire PACKET_MMAP-related part of the man-page in a single > effort. > > Updated patch follows. > > Cheers, > Carsten > Acked-by: Neil Horman <nhorman@xxxxxxxxxxxxx> Thanks! Neil -- To unsubscribe from this list: send the line "unsubscribe linux-man" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
