Hello David, On 11/14/13 08:20, David Malcolm wrote: > Currently man3/gets.3 documents various safe I/O functions, along with > the toxic "gets" function. > > At the risk of being melodramatic, this strikes me as akin to storing > rat poison in a food cabinet, in the same style of packaging as the > food, but with a post-it note on it saying "see warnings below". > > I think such "never use this" functions should be quarantined into their > own manpages, rather than listing them alongside sane functions. > > The attached patch does this for "gets", moving the documentation of the > good functions from man3/gets.3 into man3/fgetc.3, updating the SO links > in the relevant functions to point at the latter. > > It then rewrites man3/gets.3 to spell out that "gets" is toxic and > should never be used (with a link to CWE-242 for good measure). > > Thoughts? > Dave > > [Note to self: I filed this downstream as: > https://bugzilla.redhat.com/show_bug.cgi?id=1030030 ] Seems reasonable to me. Applied, with a few tweaks. Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/ -- To unsubscribe from this list: send the line "unsubscribe linux-man" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
