Re: [man-pages PATCH] Add note about calling fclose(NULL)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday 01 February 2013 04:43:21 Thomas Jarosch wrote:
> On Tuesday, 29. January 2013 13:44:28 you wrote:
> > On Tuesday 29 January 2013 11:24:43 Thomas Jarosch wrote:
> > > --- a/man3/fclose.3
> > > +++ b/man3/fclose.3
> > > @@ -97,6 +97,10 @@ on disk the kernel buffers must be flushed too, for
> > > example, with .BR sync (2)
> > >  or
> > >  .BR fsync (2).
> > > +Also it's undefined behavior to call
> > > +.BR fclose ()
> > > +with a NULL pointer.
> > > +
> > >  .SH "SEE ALSO"
> > >  .BR close (2),
> > >  .BR fcloseall (3),
> > 
> > i wonder if it'd be better placed in the DESCRIPTION section
> 
> I first added it there and then thought it's too prominent.
> The "NOTES" section seemed like a better place.

looking at other pages, argument behavior is in the DESCRIPTION rather than 
NOTES, including discussion of undefined behavior.  keeping it higher up is 
probably better too since NOTES tends to get lost by readers while DESCRIPTION 
is absorbed most frequently.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux