On Sunday 22 April 2012 14:56:14 Michael Kerrisk (man-pages) wrote: > You long ago sent the patch below, but I didn't respond. I'm just > pulling up a few old ptrace pieces now for review. > > Your patch below relates to PTRACE_GETREGS, PTRACE_GETFPREGS, > PTRACE_SETREGS, PTRACE_SETFPREGS. (The patch below no longer is > current, but is easy to fix) > > Looking at arch/sparc/kernel/ptrace_32.c, I think I see what the point > of the patch is. However, the text is a bit cryptic. Would it not be > better to say something like seemed clear to me, but i wrote it ;) > [[ > Note that SPARC systems have the meaning of \fIdata\fP and \fIaddr\fP > reversed; that is, \fIdata\fP is ignored and the registers are copied to > [from] \fIaddr\fP. > ]] i'd suggest "via" rather than "to [from]" -mike
Attachment:
signature.asc
Description: This is a digitally signed message part.