Andi, On Fri, Jun 11, 2010 at 10:31 AM, Andi Kleen <andi@xxxxxxxxxxxxxx> wrote: >> The information in this patch is rather incomplete, and is in any case >> covered more completely in sigaction(2), so I haven't applied this > > And impossible to find there. I didn't think so, but see below. >> patch. On the other hand, it triggered me to make some improvements to >> sigaction(2), as shown below. > > I still think the table is useful, I added it originally when I couldn't > find this information easily. These were the problems I had with the patch: +Signal siginfo_t fields +SIGKILL si_pid, si_uid +SIGCHLD si_pid, si_uid, si_status, si_utime, si_stime +SIGILL si_code, si_addr, si_trapno +SIGFPE si_code, si_addr, si_trapno +SIGSEGV si_code, si_addr, si_trapno +SIGBUS si_code, si_addr, si_trapno, si_addr_lsb +SIGTRAP si_code, si_addr, si_trapno +SIGPOLL si_band, si_fd +realtime signals > 32 si_pid, si_uid, si_value +posix timer si_tid, si_overrun, si_sigval * It duplicates info that can be found in sigaction(2). * It's incomplete. If you compare against the corresponding information in sigaction(2) [better pull the latest page from git for this comparison], there is more information about which fields are set by the various signals. Also, various siginfo_t fields (si_signo) are missing from your table. * It's misleading. For example, it implies that some signals set si_code while others don't. But, AFAIK, all signals set this field. Likewise, it suggests that there is useful info in si_trapno, but usually there is not. The entry for SIGKILL also seems strange. It would help if you could explain what the problem was that you were trying to solve with this patch, and explain why sigaction(2) doesn't solve the problem. Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Author of "The Linux Programming Interface" http://blog.man7.org/ -- To unsubscribe from this list: send the line "unsubscribe linux-man" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
