Re: [PATCH] man3/getaddrinfo.3: Document results ordering and /etc/gai.conf

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Petr,

On Thu, Dec 4, 2008 at 6:22 PM, Petr Baudis <pasky@xxxxxxx> wrote:
> This patch documents the order of the getaddrinfo(3) results (RFC 3484), how
> should the application deal with that, mentions the extremely common cause of
> having multiple results per query (both IPv4 and IPv6 addresses available)
> and mentions /etc/gai.conf.

Thanks for this!  I've applied this for 3.15, but with tweaks as noted below.

> Signed-off-by: Petr Baudis <pasky@xxxxxxx>
>
> diff --git a/man3/getaddrinfo.3 b/man3/getaddrinfo.3
> index b3b0cce..e1f1f9c 100644
> --- a/man3/getaddrinfo.3
> +++ b/man3/getaddrinfo.3
> @@ -33,10 +33,12 @@
>  .\" 2008-02-26, mtk; clarify discussion of NULL 'hints' argument; other
>  .\"     minor rewrites.
>  .\" 2008-06-18, mtk: many parts rewritten
> +.\" 2008-12-04, Petr Baudis <pasky@xxxxxxx>
> +.\"    Describe results ordering and reference /etc/gai.conf.

Yep.  This is a case where in-source changelog makes sense.

>  .\" FIXME . glibc's 2.9 NEWS file documents DCCP and UDP-lite support
>  .\"           and is SCTP support now also there?
>  .\"
> -.TH GETADDRINFO 3 2008-10-28 "GNU" "Linux Programmer's Manual"
> +.TH GETADDRINFO 3 2008-12-04 "GNU" "Linux Programmer's Manual"
>  .SH NAME
>  getaddrinfo, freeaddrinfo, gai_strerror \- network address and
>  service translation
> @@ -293,15 +295,26 @@ and returns a pointer to the start of the list in
>  The items in the linked list are linked by the
>  .I ai_next
>  field.
> +.PP

This change is not relevant to the subject of the patch, and unneeded.  Dropped.

>  There are several reasons why
>  the linked list may have more than one
>  .I addrinfo
> -structure, including: the network host is multi-homed; or the same service
> -is available from multiple socket protocols (one
> +structure, including: the network host is multi-homed, accessible
> +over multiple protocols (e.g. both
> +.BR AF_INET
> +and
> +.BR AF_INET6 );
> +or the same service is available from multiple socket types (one
>  .B SOCK_STREAM
>  address and another
>  .B SOCK_DGRAM
> -address, for example).
> +address, for example).  Normally, the application should try

My preference (see man-pages(7) is to start new sentences on new line.
 This is because (later) diffs at least sometimes operate at the
sentence level.

> +using the addresses in the order they are returned in.
> +The sorting function used within
> +.BR getaddrinfo ()
> +is defined in RFC\ 3484; the order can be tweaked for a particular
> +system by editing
> +.IR /etc/gai.conf .

Here, it is good to mention the glibc version that first started
supporting gai.conf.  It looks like it was 2.5, and I've added that
information.

>  .PP
>  If
>  .I hints.ai_flags
> @@ -558,6 +571,8 @@ The
>  .BR gai_strerror ()
>  function translates these error codes to a human readable string,
>  suitable for error reporting.
> +.SH "FILES"
> +.I /etc/gai.conf
>  .SH "CONFORMING TO"
>  POSIX.1-2001.
>  The

Thanks!

Michael


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
git://git.kernel.org/pub/scm/docs/man-pages/man-pages.git
man-pages online: http://www.kernel.org/doc/man-pages/online_pages.html
Found a bug? http://www.kernel.org/doc/man-pages/reporting_bugs.html
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux