Re: Patch: signalfd(2) typo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jun 7, 2008 at 7:31 PM, Sam Varshavchik <mrsam@xxxxxxxxxxxxxxx> wrote:
>
>
> --- man-pages-2.80/man2/signalfd.2~     2008-06-03 05:50:15.000000000 -0400
> +++ man-pages-2.80/man2/signalfd.2      2008-06-07 13:27:31.000000000 -0400
> @@ -168,7 +168,7 @@
> .\" ssi_trapno is unused on most (all?) arches?
>    int32_t  ssi_status;  /* Exit status or signal (SIGCHLD) */
>    int32_t  ssi_int;     /* Integer sent by sigqueue(2) */
> -    uint64_t ssi_ptr      /* Pointer sent by sigqueue(2) */;
> +    uint64_t ssi_ptr;     /* Pointer sent by sigqueue(2) */
>    uint64_t ssi_utime;   /* User CPU time consumed (SIGCHLD) */
>    uint64_t ssi_stime;   /* System CPU time consumed (SIGCHLD) */
>    uint64_t ssi_addr;    /* Address that generated signal

Hi Sam,

Thanks for the message -- I'll apply the change shortly.  A couple of things:

* For really simple stuff like this, *if it's easier for you*, then
you don't need to go to the work of writing a patch -- a few words
describing the problem ("misplaced semicolon on ssi_ptr field in
structure definition"), will suffice.

* IMO (but I'm ready to hear counter-arguments), to save list noise,
it's probably better not to CC the list on trivial patches which I'm
likely to automatically apply anyway.

Cheers,

Michael

-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
man-pages online: http://www.kernel.org/doc/man-pages/online_pages.html
Found a bug? http://www.kernel.org/doc/man-pages/reporting_bugs.html
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux