Hi Thorsten,
On Fri, 17 Jan 2025 at 13:06, Thorsten Blum <thorsten.blum@xxxxxxxxx> wrote:
Remove hard-coded strings by using the str_read_write() helper.
Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
Thanks for your patch!
Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
i.e. will queue in the m68k tree for v6.15.
--- a/arch/m68k/sun3/mmu_emu.c
+++ b/arch/m68k/sun3/mmu_emu.c
@@ -371,7 +372,7 @@ int mmu_emu_handle_fault (unsigned long vaddr, int read_flag, int kernel_fault)
#ifdef DEBUG_MMU_EMU
pr_info("%s: vaddr=%lx type=%s crp=%p\n", __func__, vaddr,
- read_flag ? "read" : "write", crp);
+ str_read_write(read_flag), crp);
You haven't really tested this with DEBUG_MMU_EMU enabled, have you?
Fix sent.
#endif
segment = (vaddr >> SUN3_PMEG_SIZE_BITS) & 0x7FF;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
