Re: [PATCH v3 2/2] m68k: mvme147, mvme16x: Adopt rtc-m48t59 platform driver

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Finn,

On Tue, Oct 8, 2024 at 10:55 AM Finn Thain <fthain@xxxxxxxxxxxxxx> wrote:
> Both mvme147 and mvme16x platforms have their own RTC driver
> implementations that duplicate functionality provided by the rtc-m48t59
> driver. Adopt the rtc-m48t59 driver and remove the other ones.
>
> Tested-by: Daniel Palmer <daniel@xxxxxxxx>
> Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxx>
> ---
> This patch depends upon the m48t59 driver changes in the preceding patch.
>
> Changed since v1:
>  - Initialize yy_offset in struct m48t59_plat_data.

> --- a/arch/m68k/configs/multi_defconfig
> +++ b/arch/m68k/configs/multi_defconfig
> @@ -506,6 +506,7 @@ CONFIG_RTC_CLASS=y
>  CONFIG_RTC_DRV_MSM6242=m
>  CONFIG_RTC_DRV_RP5C01=m
>  CONFIG_RTC_DRV_GENERIC=m
> +CONFIG_RTC_DRV_M48T59=m
>  # CONFIG_VIRTIO_MENU is not set
>  # CONFIG_VHOST_MENU is not set
>  # CONFIG_IOMMU_SUPPORT is not set
> diff --git a/arch/m68k/configs/mvme147_defconfig b/arch/m68k/configs/mvme147_defconfig
> index 2248db426081..4a0928b3b842 100644
> --- a/arch/m68k/configs/mvme147_defconfig
> +++ b/arch/m68k/configs/mvme147_defconfig
> @@ -392,6 +392,7 @@ CONFIG_UHID=m
>  CONFIG_RTC_CLASS=y
>  # CONFIG_RTC_NVMEM is not set
>  CONFIG_RTC_DRV_GENERIC=m
> +CONFIG_RTC_DRV_M48T59=y
>  # CONFIG_VIRTIO_MENU is not set
>  # CONFIG_VHOST_MENU is not set
>  # CONFIG_IOMMU_SUPPORT is not set
> diff --git a/arch/m68k/configs/mvme16x_defconfig b/arch/m68k/configs/mvme16x_defconfig
> index 2975b66521f6..481fb2810f1e 100644
> --- a/arch/m68k/configs/mvme16x_defconfig
> +++ b/arch/m68k/configs/mvme16x_defconfig
> @@ -393,6 +393,7 @@ CONFIG_UHID=m
>  CONFIG_RTC_CLASS=y
>  # CONFIG_RTC_NVMEM is not set
>  CONFIG_RTC_DRV_GENERIC=m
> +CONFIG_RTC_DRV_M48T59=y
>  # CONFIG_VIRTIO_MENU is not set
>  # CONFIG_VHOST_MENU is not set
>  # CONFIG_IOMMU_SUPPORT is not set

All of the above don't seem to be inserted at the right location?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds