Hi,
On 24.9.2024 4.03, Michael Schmitz wrote:
On 23/09/24 09:48, Eero Tamminen wrote:
Not having it configured, but crash backtraces going through its IRQ
handling code, is confusing (found while debugging issues in Atari
I don't see how backtraces could go through the EtherNAT interrupt code
- the interrupt only gets enabled if the hardware has been detected.
Maybe you meant you see the generic IRQ handling code called for the
EtherNAT's interrupt controller?
It was many years ago, but I _did_ see one of these functions in Hatari
debugger's backtrace, although I had explicitly disabled EtherNAT support.
I don't any more remember what I was debugging, but I think it's
something already fixed / supported in Hatari.
=> Better just to drop that comment?
+#ifdef CONFIG_ATARI_ETHERNAT
I believe we now use
#if IS_ENABLED(CONFIG_ATARI_ETHERNAT)
OK.
but that's perhaps a matter of taste (CONFIG_ATARI_ETHERNAT can't take
the value 'm').
>
OK by me if it helps with your debugging ...
The issue triggering it is unlikely to appear again, so it's not that
important. But I think those if(def)s are still the correct thing to do.
- Eero
PS. As m68k Linux support is rather old, most of code appears to be
still using ifdefs:
$ git grep "ifdef *CONFIG_" arch/m68k/ | wc -l
336
$ git grep IS_ENABLED arch/m68k/ | wc -l
62
$ git grep -c "ifdef CONFIG_" arch/m68k/atari/
arch/m68k/atari/ataints.c:2
arch/m68k/atari/config.c:7
arch/m68k/atari/nvram.c:1
$ git grep -c IS_ENABLED arch/m68k/atari/
arch/m68k/atari/config.c:3
